Skip to content

Commit

Permalink
keep helm wait
Browse files Browse the repository at this point in the history
Signed-off-by: Austin Abro <[email protected]>
  • Loading branch information
AustinAbro321 committed Sep 30, 2024
1 parent d8c8d5b commit db2cf16
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/internal/packager/helm/chart.go
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,7 @@ func (h *Helm) installChart(ctx context.Context, postRender *renderer) (*release
client.Timeout = h.timeout

// Default helm behavior for Zarf is to wait for the resources to deploy, NoWait overrides that for special cases (such as data-injection).
// TODO probably will not keep this, but I want to test out if kstatus will always work
client.Wait = false
client.Wait = !h.chart.NoWait

// We need to include CRDs or operator installations will fail spectacularly.
client.SkipCRDs = false
Expand Down Expand Up @@ -344,8 +343,7 @@ func (h *Helm) upgradeChart(ctx context.Context, lastRelease *release.Release, p
client.Timeout = h.timeout

// Default helm behavior for Zarf is to wait for the resources to deploy, NoWait overrides that for special cases (such as data-injection).
// TODO just testing if kstatus will always work
client.Wait = false
client.Wait = !h.chart.NoWait

client.SkipCRDs = true

Expand Down

0 comments on commit db2cf16

Please sign in to comment.