Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Hacktoberfest 2022 #1320

Conversation

ArkaprabhaChakraborty
Copy link
Contributor

Signed-off-by: ArkaprabhaChakraborty [email protected]

@ArkaprabhaChakraborty ArkaprabhaChakraborty changed the title Add hacktoberfest blog Blog: Hacktoberfest 2022 blog Sep 29, 2022
@njmulsqb
Copy link
Contributor

Looks good!

Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one minor item.

@ArkaprabhaChakraborty
Copy link
Contributor Author

Probably good to post.

@thc202 thc202 changed the title Blog: Hacktoberfest 2022 blog Blog: Hacktoberfest 2022 Sep 30, 2022
@psiinon psiinon changed the title Blog: Hacktoberfest 2022 Blog: Hacktoberfest 2022 WIP Sep 30, 2022
@psiinon
Copy link
Member

psiinon commented Sep 30, 2022

FYI changed to WIP as it should not be merged until tomorrow 😉

@ArkaprabhaChakraborty
Copy link
Contributor Author

Now I feel I could have changed the date :). But anyways :).

@psiinon
Copy link
Member

psiinon commented Sep 30, 2022

We've published the September Update blog post today so wouldnt have wanted another one until tomorrow at the earliest 😉

Copy link
Member

@ricekot ricekot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but added a few comments. Please feel free to ignore the suggestions if you feel otherwise :).

@ArkaprabhaChakraborty ArkaprabhaChakraborty force-pushed the arkaprabha/add-hacktoberfest-blog branch 3 times, most recently from d943431 to f4f084b Compare September 30, 2022 13:54
@thc202
Copy link
Member

thc202 commented Sep 30, 2022

Thank you!

@kingthorin
Copy link
Member

Looks good thanks!

@ricekot do you want to review again?

Signed-off-by: ArkaprabhaChakraborty <[email protected]>
@ArkaprabhaChakraborty
Copy link
Contributor Author

Pushed the changes should be good now

Copy link
Member

@ricekot ricekot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psiinon psiinon changed the title Blog: Hacktoberfest 2022 WIP Blog: Hacktoberfest 2022 Oct 1, 2022
@psiinon psiinon merged commit a485ad6 into zaproxy:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants