Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NotificationType names #17

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Update NotificationType names #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa5778f
Update NotificationType enum values
hiimjako Nov 14, 2023
b53da21
docs: update docs
hiimjako Nov 14, 2023
9a59c4b
Buf re-generated protos
Nov 14, 2023
70a350c
docs(release_notes): update RELEASE_NOTES.md
hiimjako Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ProtoBuf Release Notes

## 0.0.2-dev - 2023-11-13
## 0.0.2-dev - 2023-11-14

### Bug Fixes

Expand All @@ -10,3 +10,7 @@

- Update documentation to reflect protocol buffer refactoring (PR #15 by
@chicco785)

### Refactoring

- Update NotificationType names (PR #17 by @hiimjako)
18 changes: 9 additions & 9 deletions docs/task.proto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@

<div class="comment"><span>The different type of notifications generated by the real time processing.</span><br/></div>

| Name | Ordinal | Description |
|----------------------------------|---------|-------------|
| NOTIFICATION_TYPE_UNSPECIFIED | 0 | |
| NOTIFICATION_TYPE_DATA_COMPLETE | 1 | |
| NOTIFICATION_TYPE_DATA_TIMEOUT_1 | 2 | |
| NOTIFICATION_TYPE_DATA_TIMEOUT_2 | 3 | |
| NOTIFICATION_TYPE_TRIGGER | 4 | |
| Name | Ordinal | Description |
|---------------------------------------|---------|-------------|
| NOTIFICATION_TYPE_UNSPECIFIED | 0 | |
| NOTIFICATION_TYPE_DATA_COMPLETE | 1 | |
| NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT | 2 | |
| NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM | 3 | |
| NOTIFICATION_TYPE_TRIGGER | 4 | |



Expand Down Expand Up @@ -73,8 +73,8 @@ class NotificationType{
<<enumeration>>
NOTIFICATION_TYPE_UNSPECIFIED
NOTIFICATION_TYPE_DATA_COMPLETE
NOTIFICATION_TYPE_DATA_TIMEOUT_1
NOTIFICATION_TYPE_DATA_TIMEOUT_2
NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT
NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM
NOTIFICATION_TYPE_TRIGGER
}
```
Expand Down
42 changes: 21 additions & 21 deletions pkg/platform/v1/task.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions proto/platform/v1/task.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ enum TaskType {
enum NotificationType {
NOTIFICATION_TYPE_UNSPECIFIED = 0;
NOTIFICATION_TYPE_DATA_COMPLETE = 1;
NOTIFICATION_TYPE_DATA_TIMEOUT_1 = 2;
NOTIFICATION_TYPE_DATA_TIMEOUT_2 = 3;
NOTIFICATION_TYPE_DATA_TIMEOUT_SHORT = 2;
NOTIFICATION_TYPE_DATA_TIMEOUT_MEDIUM = 3;
NOTIFICATION_TYPE_TRIGGER = 4;
}

Expand Down
Loading