Adding preliminary QRE for mn_mono #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2-527/mn_mono_qre
bellonzi
requested changes
Oct 8, 2024
| with a few simplifying assumptions. First, the ground-state overlap is assumed to be | ||
| 0.8. Second, the double-factorized truncation threshold is assumed to be 1e-3 Ha. | ||
|
|
||
| In order to run this script to work, you must have credentials with read access the |
There was a problem hiding this comment.
Small grammar edit:
In order to run this script to work,
| ], | ||
| "compute_hardware_type": "quantum_computer", | ||
| "compute_details": { | ||
| "description": "Double factorized QPE resource estimates based on methodology of arXiv:2406.06335. Uses PyLIQTR logical resource estimates with BenchQ footprint analysis. Ground-state overlap assumed to be 0.8 and double-factorized truncation threshold to be 1e-3 Ha. Note that the truncation error is not included in the error bounds and that the SCF compute time is not included in the preprocessing time." |
There was a problem hiding this comment.
Might be good to capture the classical hardware used for the pre-processing. It's not needed at this point, but would be nice to have
There was a problem hiding this comment.
Do you want to remove this?
There was a problem hiding this comment.
Do we want this to live here or should it sit somewhere in the instances directory?
There was a problem hiding this comment.
I'm agnostic to the answer here, just want to check in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a preliminary QRE for mn_mono as well as the python code used to generate it. This will allow us to test out the handoff to the bubble ml tool. Note that this QRE is somewhat crude as described in the compute_details section of the JSON.