bugfix(s3-storage-argocd): Fix s3 with existing secret for argocd

[stijnbrouwers]

What this PR does / why we need it

Alternative approach to use existing secret for minio

Which issue this PR fixes

• fixes S3 storage with existing auth not working in combination with argocd #255

Special notes for your reviewer

/

Checklist

• Chart Version bumped
• Upgrading instructions are documented in the zammad/README.md

[mgruner]

@stijnbrouwers thank you for your suggestion. This time I'm skeptical about your change, for two reasons:

• lookup is a standard helm function
• Using your approach based on it, we can do proper URL encoding of the passwords as described in Postgresql credentials should be percent encoded #251. This is not possible if we remove it again.

My plan is to improve secrets handling using lookup and proper URL encoding in #254.

[mgruner]

If we cannot use lookup as also suggested by @monotek, then your changes look good. Thank you!

[stijnbrouwers]

@mgruner thanks!
Yeah, too bad the lookup apparently isn't always supported because I can see the need to do url encoding and don't know a (easy) way around it in the current setup...

[mgruner]

Yes. I think I will change the Chart at some point so that values from the config can be percent encoded, but values from secrets simply can't.