Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #261 - Added note for oversized emails / small changes #288

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

ralf401
Copy link
Contributor

@ralf401 ralf401 commented Aug 23, 2023

No description provided.

@ralf401 ralf401 self-assigned this Aug 23, 2023
@ralf401 ralf401 requested a review from mgruner August 23, 2023 09:50
@ralf401 ralf401 changed the title Fixes #261 - Added note for oversitzed emails / small changes Fixes #261 - Added note for oversized emails / small changes Aug 23, 2023
@ralf401 ralf401 linked an issue Aug 23, 2023 that may be closed by this pull request
@ralf401
Copy link
Contributor Author

ralf401 commented Aug 23, 2023

Hi @mgruner, can you have a brief look? I just added a note for oversized emails (and converted one existing note) , adjusted (cropped) one image and inserted some linebreaks.

Thank you!

Copy link
Contributor

@mgruner mgruner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry Ralf, I comment on the text that you didn't change. Do you think we have a chance of improving it? Let me know if anything is unclear.

system/monitoring.rst Show resolved Hide resolved
system/monitoring.rst Outdated Show resolved Hide resolved
system/monitoring.rst Outdated Show resolved Hide resolved
@ralf401
Copy link
Contributor Author

ralf401 commented Aug 23, 2023

@mgruner your comments are absolutely right. I used it as an opportunity to completely overhaul the page. I hope this is ok. Feel free to suggest changes :-)

@ralf401 ralf401 requested a review from mgruner August 23, 2023 14:23
Copy link
Contributor

@mgruner mgruner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

system/monitoring.rst Show resolved Hide resolved
@ralf401 ralf401 merged commit aabdf6b into pre-release Aug 24, 2023
1 check passed
@ralf401 ralf401 deleted the rsc/fixes/261/monitoring branch August 24, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring documentation outdated
2 participants