Skip to content

Commit

Permalink
Use gray icon by default for page action to fix regression in Chrome
Browse files Browse the repository at this point in the history
Related to #600
  • Loading branch information
zalmoxisus committed Dec 1, 2018
1 parent dcc9495 commit 05f4dc1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion src/app/middlewares/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ function onConnect(port) {
connections.tab[id] = port;
listener = msg => {
if (msg.name === 'INIT_INSTANCE') {
if (typeof id === 'number') chrome.pageAction.show(id);
if (typeof id === 'number') {
chrome.pageAction.show(id);
chrome.pageAction.setIcon({tabId: id, path: 'img/logo/38x38.png'});
}
if (isMonitored) port.postMessage({ type: 'START' });

const state = window.store.getState();
Expand Down
Binary file added src/assets/img/logo/gray.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/browser/extension/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"homepage_url": "https://github.com/zalmoxisus/redux-devtools-extension",
"manifest_version": 2,
"page_action": {
"default_icon": "img/logo/38x38.png",
"default_icon": "img/logo/gray.png",
"default_title": "Redux DevTools",
"default_popup": "window.html#popup"
},
Expand Down

0 comments on commit 05f4dc1

Please sign in to comment.