Improve CI build speed #1956
Open
Improve CI build speed #1956
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msdousti
requested review from
whiskeysierra,
lukasniemeier-zalando and
kasmarian
as code owners
kasmarian
approved these changes
Nov 11, 2024
msdousti
force-pushed
the
improve-ci-build
branch
from
69d70b9
to
fb8808e
Compare
|
@kasmarian As per discussion, added a |
kasmarian
reviewed
Nov 19, 2024
| # Execute commands based on the flags | ||
| if $COMPILE; then | ||
| echo "Running compile..." | ||
| eval "$COMPILE_CMD" |
There was a problem hiding this comment.
Would the compilation work without packaging the servlet module first? Same question to install command.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve CI build speed by not running Maven package for the whole project. Using the past execution statistics, the build used to take
5 mins, which is now improved to3 mins🙂Description
Due to the Maven shade plugin for
logbook-servletmodule, we need to run package once without running tests, and then run verify.This can be improved by limiting the package step to the
logbook-servletmodule only (plus its dependencies)Motivation and Context
This is a minor change to the CI build step, and improves the build speed.
Types of changes
Checklist: