Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showpenalty option #54

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Add showpenalty option #54

merged 4 commits into from
Oct 18, 2024

Conversation

PaulWalther
Copy link

@PaulWalther PaulWalther commented Oct 17, 2024

As we do not use penalties in our course we wanted to add this additional option to avoid showing the penalty to the students.

Copy link
Owner

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PaulWalther, thank you for your contribution.

It LGTM, could you just address the suggested styling issues before I can merge this? Thank you.

src/turnin.c Outdated Show resolved Hide resolved
src/turnin.c Outdated Show resolved Hide resolved
src/turnin.c Outdated Show resolved Hide resolved
@PaulWalther
Copy link
Author

Hey @zakkak . Sure, should have looked into the styleguide before opening the PR. I applied your changes. Best regards

Copy link
Owner

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @PaulWalther

@zakkak zakkak merged commit d907833 into zakkak:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants