Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Whatsapp Link #83

Merged
merged 37 commits into from
Feb 26, 2022
Merged

Conversation

AchmadWahyu
Copy link
Contributor

@AchmadWahyu AchmadWahyu commented Dec 30, 2021

Closes #79

Description

Implement the WhatsApp interaction parts of the Transaction Flow

Current Tasks

  • Write the transaction information into the database upon the form submission
  • Redirect to /dashboard/purchase/confirm/$transactionId route upon a successful response
  • Implement Centered with single action modal in a /dashboard/purchase/confirm/$transactionId.tsx file
  • Render a Remix's Outlet component somewhere in /dashboard/purchase/confirm.tsx file to render the modal above
  • Write end-to-end test scenarios to cover all the steps above, including verifying the link to the WhatsApp web page

@AchmadWahyu AchmadWahyu marked this pull request as ready for review January 1, 2022 14:18
@AchmadWahyu
Copy link
Contributor Author

Please for the review and correction, Mas Zain @zainfathoni 😁🙏, especially on the line where I fill fields for transaction schema, I'm still confused whether it is true or not, and should I assign subscription to db first to get subscriptionId?

app/routes/dashboard/purchase/confirm.tsx Outdated Show resolved Hide resolved
app/routes/dashboard/purchase/confirm.tsx Outdated Show resolved Hide resolved
@zainfathoni zainfathoni marked this pull request as draft January 2, 2022 22:02
@AchmadWahyu AchmadWahyu changed the title feat: added confirm remix outlet component feat: Whatsapp Link Jan 8, 2022
@AchmadWahyu AchmadWahyu marked this pull request as ready for review January 8, 2022 05:40
@AchmadWahyu
Copy link
Contributor Author

Please for the review Mas @zainfathoni . Especially where i throw error if response not found on loader function. I also has another question, on confirm page when I fill the fields for transaction, how could I retrieve courseId value?

@zainfathoni
Copy link
Owner

Please for the review Mas @zainfathoni . Especially where i throw error if response not found on loader function. I also has another question, on confirm page when I fill the fields for transaction, how could I retrieve courseId value?

Okay, I'll review it later tonight. If possible, I can also make some changes to your code directly.

@AchmadWahyu
Copy link
Contributor Author

AchmadWahyu commented Jan 8, 2022

Please for the review Mas @zainfathoni . Especially where i throw error if response not found on loader function. I also has another question, on confirm page when I fill the fields for transaction, how could I retrieve courseId value?

Okay, I'll review it later tonight. If possible, I can also make some changes to your code directly.

Okay Mas, thank you. Please let me know if there is something that need to be addressed. For the test, I'm still trying to work on it

@AchmadWahyu
Copy link
Contributor Author

I'm sorry Mas @zainfathoni , i'm still working on this issue, i will make this pr to draft again 🙏

@AchmadWahyu AchmadWahyu marked this pull request as draft January 8, 2022 11:32
@zainfathoni
Copy link
Owner

I'm sorry Mas @zainfathoni, I'm still working on this issue, I will make this pr to draft again 🙏

No problem. In the meantime, I'll try to document the testing methods and principles so that it's easier for beginners to follow along.

@AchmadWahyu
Copy link
Contributor Author

I'm sorry Mas @zainfathoni, I'm still working on this issue, I will make this pr to draft again 🙏

No problem. In the meantime, I'll try to document the testing methods and principles so that it's easier for beginners to follow along.

Thankyou Mas @zainfathoni !

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022

Codecov Report

Merging #83 (ed3ddf5) into main (a144f51) will increase coverage by 8.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   10.79%   19.01%   +8.21%     
==========================================
  Files          52       37      -15     
  Lines         463      263     -200     
  Branches      142       61      -81     
==========================================
  Hits           50       50              
+ Misses        413      213     -200     
Impacted Files Coverage Δ
app/models/course.ts 0.00% <0.00%> (ø)
app/models/transaction.ts 0.00% <0.00%> (ø)
app/utils/constants.ts 100.00% <ø> (ø)
app/utils/format.ts 0.00% <0.00%> (ø)
app/utils/misc.ts 0.00% <0.00%> (ø)
app/routes/dashboard/purchase.tsx
app/routes/dashboard/purchase/completed.tsx
app/routes/dashboard/purchase/confirm.tsx
app/routes/dashboard/purchase/index.tsx
app/routes/dashboard/profile.tsx
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a144f51...ed3ddf5. Read the comment docs.

@zainfathoni zainfathoni self-assigned this Feb 25, 2022
@zainfathoni zainfathoni marked this pull request as ready for review February 26, 2022 06:54
@zainfathoni zainfathoni added the automerge To be merged automatically once all the requirements are fulfilled label Feb 26, 2022
@kodiakhq kodiakhq bot merged commit 3853d54 into zainfathoni:main Feb 26, 2022
@zainfathoni
Copy link
Owner

@all-contributors please add @AchmadWahyu for code and test.

@allcontributors
Copy link
Contributor

@zainfathoni

I've put up a pull request to add @AchmadWahyu! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge To be merged automatically once all the requirements are fulfilled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WhatsApp Link
3 participants