-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Whatsapp Link #83
feat: Whatsapp Link #83
Conversation
…agi.com into feature/79-whatsapp-link
…agi.com into feature/79-whatsapp-link
…ahyu/kelas.rumahberbagi.com into feature/79-whatsapp-link
Please for the review and correction, Mas Zain @zainfathoni 😁🙏, especially on the line where I fill fields for transaction schema, I'm still confused whether it is true or not, and should I assign subscription to db first to get subscriptionId? |
…agi.com into feature/79-whatsapp-link
Please for the review Mas @zainfathoni . Especially where i throw error if response not found on loader function. I also has another question, on confirm page when I fill the fields for transaction, how could I retrieve courseId value? |
Okay, I'll review it later tonight. If possible, I can also make some changes to your code directly. |
Okay Mas, thank you. Please let me know if there is something that need to be addressed. For the test, I'm still trying to work on it |
I'm sorry Mas @zainfathoni , i'm still working on this issue, i will make this pr to draft again 🙏 |
No problem. In the meantime, I'll try to document the testing methods and principles so that it's easier for beginners to follow along. |
Thankyou Mas @zainfathoni ! |
…agi.com into feature/79-whatsapp-link
…ahyu/kelas.rumahberbagi.com into feature/79-whatsapp-link
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 10.79% 19.01% +8.21%
==========================================
Files 52 37 -15
Lines 463 263 -200
Branches 142 61 -81
==========================================
Hits 50 50
+ Misses 413 213 -200
Continue to review full report at Codecov.
|
until Remix officially provides routes testing infrastructure
so that the subsequent submissions will update the first transaction instead of create a new one
@all-contributors please add @AchmadWahyu for code and test. |
I've put up a pull request to add @AchmadWahyu! 🎉 |
Closes #79
Description
Implement the WhatsApp interaction parts of the Transaction Flow
Current Tasks
Write end-to-end test scenarios to cover all the steps above, including verifying the link to the WhatsApp web page