Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cta to purchase the course #60

Merged
merged 9 commits into from
Dec 26, 2021
Merged

Conversation

retry19
Copy link
Contributor

@retry19 retry19 commented Dec 25, 2021

Closes #36

Description

Call to action to purchase the course.

Current Tasks

  • Render the CTA inside the content section of the dashboard.tsx page
  • Implement the redirect action to /dashboard/purchase route
  • Implement an empty /dashboard/purchase route page
  • Write an end-to-end test case for Scenario 1 under e2e/cta.spec.ts file
  • Implement <Outlet /> in dashboard
  • Move settings component into /dashboard/settings page
  • Add new scenario on e2e for settings

@retry19 retry19 marked this pull request as draft December 25, 2021 08:49
- add outlet component
- move settings component to /dashboard/settings page
@retry19 retry19 marked this pull request as ready for review December 25, 2021 15:15
@zainfathoni zainfathoni added the automerge To be merged automatically once all the requirements are fulfilled label Dec 25, 2021
Copy link
Owner

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes look good to me. Thanks for working on it, @retry19! 🙏

However, some queries violate our testing guidelines, especially in terms of querying form elements.

We need to make sure that we implement accessible forms. Therefore, using accessible queries is very important to ensure that our features are accessible. Please perform the corresponding changes. Thanks!

e2e/cta.spec.ts Show resolved Hide resolved
e2e/settings.spec.ts Outdated Show resolved Hide resolved
@zainfathoni zainfathoni added this to the Hackathon milestone Dec 25, 2021
@retry19
Copy link
Contributor Author

retry19 commented Dec 25, 2021

s. Therefore, using accessible queries is very important to ensure that our features are accessible. Please perform the corresponding changes. Thanks!

Ok, I'll update it

Copy link
Owner

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯
Thanks for making the requested changes! 🙏

@kodiakhq kodiakhq bot merged commit 4eb7538 into zainfathoni:main Dec 26, 2021
@zainfathoni zainfathoni removed this from the Hackathon milestone Dec 26, 2021
@zainfathoni
Copy link
Owner

@all-contributors please add @retry19 for test

@allcontributors
Copy link
Contributor

@zainfathoni

I've put up a pull request to add @retry19! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge To be merged automatically once all the requirements are fulfilled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTA
2 participants