-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cta to purchase the course #60
Conversation
b50d41e
to
7b232ea
Compare
- add outlet component - move settings component to /dashboard/settings page
5bc1b8f
to
4d37ec6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the changes look good to me. Thanks for working on it, @retry19! 🙏
However, some queries violate our testing guidelines, especially in terms of querying form elements.
We need to make sure that we implement accessible forms. Therefore, using accessible queries is very important to ensure that our features are accessible. Please perform the corresponding changes. Thanks!
Ok, I'll update it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thanks for making the requested changes! 🙏
@all-contributors please add @retry19 for test |
I've put up a pull request to add @retry19! 🎉 |
Closes #36
Description
Call to action to purchase the course.
Current Tasks
dashboard.tsx
page/dashboard/purchase
route/dashboard/purchase
route pagee2e/cta.spec.ts
file<Outlet />
in dashboard/dashboard/settings
page