Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
4678: Remove 'juliet' from the binary port r=jacek-casper a=rafal-ch

This PR changes the communication method of the binary port from 'juliet' to tokio framed transport.

Single frame is just a `Bytes` to make the integration with the current code seamless by emulating the juliet message payload.

In the future we might consider using a typed codec for `BinaryRequest` and `BinaryResponse`, however, this might require some refactoring due to our special treatment of `BinaryRequest` (we first parse the header and then decide if we can handle the request).

[PR](casper-network/casper-sidecar#289) to the Sidecar will follow after this one is merged.

Co-authored-by: Rafał Chabowski <[email protected]>
Co-authored-by: Jacek Malec <[email protected]>
  • Loading branch information
3 people authored Apr 29, 2024
2 parents d6cf1e7 + 3b6ad2d commit 44e99ef
Show file tree
Hide file tree
Showing 15 changed files with 332 additions and 187 deletions.
83 changes: 6 additions & 77 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions binary_port/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ license = "Apache-2.0"
exclude = ["proptest-regressions"]

[dependencies]
bytes = "1.0.1"
casper-types = { version = "5.0.0", path = "../types", features = ["datasize", "json-schema", "std"] }
serde = { version = "1.0.183", features = ["derive"] }
thiserror = "1.0.45"
Expand All @@ -19,6 +20,7 @@ once_cell = { version = "1.5.2" }
schemars = { version = "0.8.16", features = ["preserve_order", "impl_json_schema"] }
bincode = "1.3.3"
rand = "0.8.3"
tokio-util = { version = "0.6.4", features = ["codec"] }

[dev-dependencies]
casper-types = { path = "../types", features = ["datasize", "json-schema", "std", "testing"] }
Expand Down
Loading

0 comments on commit 44e99ef

Please sign in to comment.