New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teddav changes #20

Open

teddav wants to merge 1 commit into zBlock-2:v2 from teddav:zblock2-teddav-changes

teddav commented Apr 29, 2024 •

edited

Loading

Made a few changes.

In Yul, if we want to return an error string we can't just store it in memory and return it, otherwise it won't be interpreted correctly. We need to the Error(string) function signature.
There are a few other improvements that could be made in the verifier to improve gas usage, but it's probably useless because it's a view function, so one would care 😄
added some comments in csv_parser.rs for things that could be improved


          teddav changes

a218a30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet