use else instead of continue

why is this so much faster wtf
z3y · Nov 1, 2023 · 469dd4a · 469dd4a
1 parent 6a8d344
commit 469dd4a
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/Runtime/CBIRPLight.asset b/Runtime/CBIRPLight.asset
@@ -12,7 +12,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: c333ccfdd0cbdbc4ca30cef2dd6e6b9b, type: 3}
   m_Name: CBIRPLight
   m_EditorClassIdentifier: 
-  serializedUdonProgramAsset: {fileID: 11400000, guid: 43a3e7496e111fb4cbf2abc3487f26e1,
+  serializedUdonProgramAsset: {fileID: 11400000, guid: dcaf1c08714cfe747acd9d9d7aec871b,
     type: 2}
   udonAssembly: 
   assemblyError: 

diff --git a/Runtime/CBIRPManager.asset b/Runtime/CBIRPManager.asset
@@ -12,7 +12,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: c333ccfdd0cbdbc4ca30cef2dd6e6b9b, type: 3}
   m_Name: CBIRPManager
   m_EditorClassIdentifier: 
-  serializedUdonProgramAsset: {fileID: 11400000, guid: 97f666214d09bce4eaface49713984a4,
+  serializedUdonProgramAsset: {fileID: 11400000, guid: 26380f5940f05bd48bba8b948e65f4be,
     type: 2}
   udonAssembly: 
   assemblyError: 

diff --git a/Runtime/CBIRPReflectionProbe.asset b/Runtime/CBIRPReflectionProbe.asset
@@ -12,7 +12,7 @@ MonoBehaviour:
   m_Script: {fileID: 11500000, guid: c333ccfdd0cbdbc4ca30cef2dd6e6b9b, type: 3}
   m_Name: CBIRPReflectionProbe
   m_EditorClassIdentifier: 
-  serializedUdonProgramAsset: {fileID: 11400000, guid: 2cb8794cf72572042bf76e67a2d3e34a,
+  serializedUdonProgramAsset: {fileID: 11400000, guid: 47beab666ce76aa47aaca52d948634cf,
     type: 2}
   udonAssembly: 
   assemblyError: 

diff --git a/Shaders/cbirp.hlsl b/Shaders/cbirp.hlsl
@@ -22,14 +22,16 @@ Texture2D _Udon_CBIRP_ShadowMask;
     uint4 flags4 = flags4x & flags4y & flags4z; \
     uint flags = flags4.x; \
     uint component = 0; \
-    while (component < 3) { \
-        [branch] if (flags == 0) { flags = component == 0 ? flags4.y : (component == 1 ? flags4.z : flags4.w); component++; continue; } \
+    while (true) { \
+        [branch] if (component >= 3) break; \
+        [branch] if (flags == 0) { flags = component == 0 ? flags4.y : (component == 1 ? flags4.z : flags4.w); component++;} \
+        else { \
         uint index = firstbitlow(flags); \
         flags ^= 0x1 << index; \
         index += 32 * component; \
 
 #define CBIRP_CLUSTER_END \
-    } \
+    }} \
 
 // uniform float _Udon_CBIRP_CullFar;
 // uniform float4 _Udon_CBIRP_PlayerCamera;
@@ -219,12 +221,13 @@ debug+=1;
                 }
                 #endif
 
+                attenuation *= NoL;
                 debug += attenuation > 0;
-
+                
                 UNITY_BRANCH
-                if (attenuation > 0 && NoL > 0)
+                if (attenuation > 0)
                 {
-                    half3 currentDiffuse = attenuation * light.color * NoL;
+                    half3 currentDiffuse = attenuation * light.color;
 
                     float3 halfVector = CBIRP::SafeNormalize(L + viewDirectionWS);
                     half LoH = saturate(dot(L, halfVector));