Skip to content

Commit

Permalink
Test refactor: separate Task validation tests for propagation
Browse files Browse the repository at this point in the history
To support propagated parameters in inline Task specs, validation of variable usage
is skipped for inline Task specs and performed only for referenced Tasks.
This commit refactors TestTaskSpecValidateError to split out the test cases which rely
on this validation logic from test cases that rely on validation logic that is always performed.
Since validation logic for usage of declared variables should always be performed when a Task
is created directly (but not always for a Task spec), it updates these tests to validate a Task
rather than a Task spec. This refactoring will make cleanup for propagated parameters easier.
No functional changes.
  • Loading branch information
lbernick authored and xiaowu.zhu committed May 19, 2023
1 parent f870ce3 commit 8406e46
Show file tree
Hide file tree
Showing 2 changed files with 416 additions and 350 deletions.
Loading

0 comments on commit 8406e46

Please sign in to comment.