Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.3, multi anim definitions, added options, global defaults... more #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AckerApple
Copy link

@AckerApple AckerApple commented Feb 27, 2017

I've been trying to move from ng1 to ng2 for the 2nd time in my career and yet AGAIN I'm going back to AngularJs because ng2 is just not mature enough yet (UPDATE:3/1/17: I'm back at ng2, again).

I didn't want to lose some of your code that I had modified. I had to hack your code in different ways to dumb it down, as I'm not up to date on TypeScript but I got your code working with more flexibility.

What's included in this pull request:

1 - The ability to define multiple animation collections, by name. See updated README
2 - Setup the future of this package to support staggered animations. Although not yet supported.
3 - The ability to define animation defaults so every reuse, reuses the altered defaults.
4 - Added another way to define animation collections by using animateConfig(options) instead of an array of arguments like with animateFactory
5 - Updated docs with several helpful documentation flavors.

Do whatever you see fit for this pull request. Again, just trying to not waste code that I cannot use (UPDATE:3/1/17: I'm using this code).

If curious, I'm stopping Angular2 developments for now, for some of the following reasons:

1 - Staggering animations not yet supported in ng2 built-in animation stacking (2/27/17)
2 - Not able to find ngAnimateSwap replacement but this wasn't a show stopper
3 - Lack of packages to choose from like AngularJs, lack of peer programmers with knowledge.
4 - The overall learning curve is so steap: Documentation is lacking, many varying ways to pack and bundle code creates convolution
5 - Including non-js code in Typescript is complicated but doable but in-general I've had to go back and forth "trying" changes to a tsconfig file I never had before.

Farewell. Thanks for fielding my pull request

@AckerApple
Copy link
Author

After a night of sleeping on it. I'm at Angular2, again, knowing I wont have staggered animations for sometime. We shall see.

Updated version number of pull request. Added new whileStyle option. Added more documentation.

Again, not expecting a pull request acceptance. High level playing around I suppose.

@AckerApple AckerApple changed the title An example to possibly improve V1.3, multi anim definitions, added options, global defaults... more Feb 28, 2017
@AckerApple
Copy link
Author

Added option that allows more granular control over what state change ignites an animation transition. I was experiencing an extra undesired animation when an animated ngFor lived inside of an animated ngIf. New igniter option allowed me to set "void" as the only state change trigger.

@AckerApple
Copy link
Author

Yoooooooooooooooo, you were too slow: https://www.npmjs.com/package/ack-angular-fx#credits

They will now see my face instead of yours. I really didn't want to publish another package that does almost the same as yours. Lack of any communication forced me into doing so.

Farewell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant