Kyligence#92 remove internal keywords

yugan95 · Dec 18, 2019 · 804a888 · 804a888
1 parent 459f68c
commit 804a888
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 18 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
@@ -88,13 +88,10 @@ trait ExternalCatalog {
 
   def setCurrentDatabase(db: String): Unit
 
-  /** KAP#16210 */
   def listRoleUsers(roleName: String): Seq[String]
 
-  /** KAP#16210 */
   def listUserRoles(userName: String): Seq[String]
 
-  /** KAP#16210 */
   def getReadablePrincipals(dbName: String, tableName: String): Map[String, Seq[String]]
 
   // --------------------------------------------------------------------------

diff --git a/...st/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogWithListener.scala b/...st/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogWithListener.scala
@@ -81,17 +81,14 @@ class ExternalCatalogWithListener(delegate: ExternalCatalog)
     delegate.setCurrentDatabase(db)
   }
 
-  /** KAP#16210 */
   override def listRoleUsers(roleName: String): Seq[String] = {
     delegate.listRoleUsers(roleName)
   }
 
-  /** KAP#16210 */
   override def listUserRoles(userName: String): Seq[String] = {
     delegate.listUserRoles(userName)
   }
 
-  /** KAP#16210 */
   override def getReadablePrincipals(dbName: String,
                                      tableName: String): Map[String, Seq[String]] = {
     delegate.getReadablePrincipals(dbName, tableName)

diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
@@ -176,17 +176,14 @@ class InMemoryCatalog(
 
   override def setCurrentDatabase(db: String): Unit = { /* no-op */ }
 
-  /** KAP#16210 */
   override def listRoleUsers(roleName: String): Seq[String] = {
     Seq.empty;
   }
 
-  /** KAP#16210 */
   override def listUserRoles(userName: String): Seq[String] = {
     Seq.empty
   }
 
-  /** KAP#16210 */
   override def getReadablePrincipals(dbName: String,
                                      tableName: String): Map[String, Seq[String]] = {
     Map.empty

diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
@@ -227,17 +227,14 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, hadoopConf: Configurat
     client.setCurrentDatabase(db)
   }
 
-  /** KAP#16210 */
   override def listRoleUsers(roleName: String): Seq[String] = withClient {
     client.listRoleUsers(roleName)
   }
 
-  /** KAP#16210 */
   override def listUserRoles(userName: String): Seq[String] = withClient {
     client.listUserRoles(userName)
   }
 
-  /** KAP#16210 */
   override def getReadablePrincipals(dbName: String,
                                      tableName: String): Map[String, Seq[String]] = withClient {
     client.getReadablePrincipals(dbName, tableName)

diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClient.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClient.scala
@@ -289,13 +289,10 @@ private[hive] trait HiveClient {
   /** Used for testing only.  Removes all metadata from this instance of Hive. */
   def reset(): Unit
 
-  /** KAP#16210 */
   def listRoleUsers(roleName: String): Seq[String]
 
-  /** KAP#16210 */
   def listUserRoles(userName: String): Seq[String]
 
-  /** KAP#16210 */
   def getReadablePrincipals(dbName: String, tableName: String): Map[String, Seq[String]]
 
 }
diff --git a/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala b/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
@@ -687,7 +687,6 @@ private[hive] class HiveClientImpl(
     client.getTablesByPattern(dbName, pattern).asScala
   }
 
-  /** KAP#16210 */
   override def listRoleUsers(roleName: String): Seq[String] = withHiveState {
     val resp = client.getMSC.get_principals_in_role(new GetPrincipalsInRoleRequest(roleName))
     if (resp == null || resp.getPrincipalGrants == null) {
@@ -699,7 +698,6 @@ private[hive] class HiveClientImpl(
       .map(_.getPrincipalName)
   }
 
-  /** KAP#16210 */
   override def listUserRoles(userName: String): Seq[String] = withHiveState {
     val resp = client.getMSC.list_roles(userName, PrincipalType.USER)
     if (resp == null) {
@@ -708,7 +706,6 @@ private[hive] class HiveClientImpl(
     resp.asScala.map(_.getRoleName)
   }
 
-  /** KAP#16210 */
   override def getReadablePrincipals(dbName: String,
                                      tableName: String): Map[String, Seq[String]] = withHiveState {
     val privileges = client.getMSC.list_privileges(null, null,