Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUDGA-24634] Improved formatting for DB Audit logging #271

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Siddarth-Baldwa
Copy link
Contributor

Summary

This update improves the readability of the DB Audit Logging output by refining its format and removing unnecessary attributes. Key changes include:

  1. Enhanced Tabular Formatting: Improved the layout for easier readability and visual appeal.
  2. Simplified Output: Removed non-essential attributes, such as Integration ID and Date Created, focusing on the most relevant details for the user.

Command and Output Comparison

Command Example:

./ybm cluster db-audit-logging describe --cluster-name humorous-finch -o table

Old Output:

ID                                     Date Created               Cluster ID                             Integration ID                         State     Ysql Config
9e3fabbc-849c-4a77-bdb2-9422e712e7dc   2024-02-27T06:30:51.304Z   5f80730f-ba3f-4f7e-8c01-f8fa4c90dad8   7c07c103-e3b2-48b6-ac30-764e9b5275e1   ACTIVE    {"log_settings":{"log_catalog":true,"log_client":true,"log_level":"LOG","log_parameter":false,"log_relation":false,"log_statement_once":false},"statement_classes":["READ","WRITE"]}

New Output:

State     Integration Name
ACTIVE    sbal-dd

Ysql Config Key      Ysql Config Value
statement-classes    [READ, FUNCTION, ROLE, DDL, WRITE, MISC]
log-catalog          true
log-client           true
log-level            LOG
log-parameter        true
log-relation         true
log-statement-once   true

This updated format makes the DB Audit Logging output cleaner, more focused, and easier to read.

Copy link
Contributor

@harshitha-yb harshitha-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm if all relevant fields are covered in the response

@Siddarth-Baldwa Siddarth-Baldwa merged commit 0bbbe97 into main Nov 13, 2024
1 check passed
@Siddarth-Baldwa Siddarth-Baldwa deleted the CLOUDGA-24211 branch November 13, 2024 10:15
@Siddarth-Baldwa Siddarth-Baldwa changed the title [CLOUDGA-24211] Improved formatting for DB Audit logging [CLOUDGA-24634] Improved formatting for DB Audit logging Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants