Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C Library #89

Merged
merged 36 commits into from
Sep 12, 2023
Merged

C Library #89

merged 36 commits into from
Sep 12, 2023

Conversation

cindytsai
Copy link
Collaborator

C Library

  • Make libyt a C library. It is now compatible both in C and C++.
    • libyt defined struct now contains only constructor.
    • The constructor is there only if the library is compiled under g++.
    • Other checking and printing methods are moved elsewhere.
  • Hide internal libyt data away from user, and use LibytProcessControl (Singleton) to keep track of the data.
    • Process check points like libyt_initialized, param_yt_set ... are all moved to this class.
    • field_list, particle_list, grids_local, num_grids_local_MPI originally under yt_param_yt are also moved to this class.
  • Add libyt.libyt_info dict to libyt Python module. It keeps libyt info:
    • libyt_info["version"]: a tuple with version (major, minor, micro)
    • `libyt_info["interactive_mode"]: true/false, if it is in interactive mode or not.
  • Allow user to set INSTALL_PREFIX to install libyt to somewhere else.

Fix Bug

  • Fix bug when checking non-zero indexing hierarchy.

Update Doc

  • Fix GitHub alerted vulnerabilities activesupport, nokogiri.

GitHub Action

  • GitHub Action now tests if libyt can successfully installed to INSTALL_PREFIX.

@cindytsai
Merge branch 'doc' into main
b1134f4
@cindytsai
Update notes.
93c2073
@cindytsai
Build with cmake, CLion finally recognize my file.
414e8e3 
Bug: cannot compile with -Dxxx, which is now libyt only compiles to interactive mode.
@cindytsai
Create LibytProcessControl singleton class, which manages internal data.
a82b6cc 
I know it is a bad practice to use singleton.
What I'm trying to do is to make libyt a C-library and hide libyt internal data from users with minimal changes to code.
I have plans to refactor libyt, so that it is easier to add more stuff. ()
@cindytsai
Adding LibytProcessControl.cpp to cmake.
0ae8c9d 
There are some bugs in CMakeLists.txt, but at least CLion recognize my project file.
Will come back to fix this in this PR.
@cindytsai
Move check points from yt_param_libyt to LibytProcessControl
1a40e2b
@cindytsai
Move field_list, particle_list, grids_local, num_grids_local_MPI into…
72457c5 
… LibytProcessControl singleton.

Hide libyt internal data away from user with minimal changes in source code. They are now inside LibytProcessControl singleton.
@cindytsai
Update doc.
46fafe2
@cindytsai
Remove struct method in yt_param_yt and typedef struct name and enums.
4bffa10
@cindytsai
Remove struct method in yt_grid.
2f75299
@cindytsai
Use reference instead of copying.
4b6c6d2
@cindytsai
Fix bug when checking non-zero indexing hierarchy.
45cfacf
@cindytsai
Remove struct method in yt_field.
0453752
@cindytsai
Remove struct method in yt_attribute and yt_particle.
0babfb2 
Fix the bug of not including string.h header in example.cpp, since I have removed string.h header out of yt_type_particle.h.
@cindytsai
Make yt_array compatible with C.
065b3a0
@cindytsai
Include stdbool.h if in C.
199bc49
@cindytsai
Remove unnecessary headers.
3ab5864
@cindytsai
Update cmake.
2f119f0
@cindytsai
Add LIBYT_VERSION in libyt.h, and make sure log_info only prints on r…
78686ee 
…oot.
@cindytsai
Remove YT_ABORT and log_error out of yt_macro.h
93b969d 
Since yt_macro.h is part of libyt API, but we don't need these two functions. It is for internal libyt usage.
@cindytsai
Fix prompt type to const char * in interactive mode.
b356c8f
@cindytsai
Fix spaces, and add cxx_std_11 compiler feature.
c726897 
Though I updated cmake and it worked on my machine, I think it is not ready to merge to main, since I still cannot make it to use mpicxx or specify g++ compiler. Some designed mpicxx compiler for specific CPUs or HPC systems may crash, even though I haven't tested yet.
@cindytsai
Update make install to use install, and can set INSTALL_PREFIX.
de97d30
@cindytsai
Set libyt info in libyt.libyt_info, add LIBYT_MAJOR/MINOR/MICRO_VERSI…
ea3f752 
…ON macro..

Set version in libyt_info["version"], and other info.
@cindytsai
Use LIBYT_MAJOR/MINOR/MICRO_VERSION in Makefile.
258b978
@cindytsai
Update github action to test make install with install prefix set.
2e54bf0
@cindytsai
Fix typo.
99f727a
@cindytsai
Fix typo.
d47e7d1
@cindytsai
Fix white spaces.
eeecfd7
@cindytsai
Trying to fix deprecate warning in github action.
1da9f53 
blablabla about replacing node12 with node16.
@cindytsai cindytsai added bug Something isn't working doc Improvements or additions to documentation enhancement New feature or request new-feature New feature. labels Sep 11, 2023
@cindytsai cindytsai self-assigned this Sep 11, 2023
@cindytsai cindytsai merged commit 0809b0e into yt-project:main Sep 12, 2023
4 checks passed
@cindytsai cindytsai mentioned this pull request Sep 12, 2023
Closed
@cindytsai cindytsai deleted the PR-CLibrary branch September 12, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cindytsai cindytsai

Labels
bug Something isn't working doc Improvements or additions to documentation enhancement New feature or request new-feature New feature.
Projects
No open projects
libyt-v0.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cindytsai