Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for release v0.1 #109

Merged
merged 13 commits into from
Aug 29, 2024
Merged

Prepare for release v0.1 #109

merged 13 commits into from
Aug 29, 2024

Conversation

cindytsai
Copy link
Collaborator

@cindytsai cindytsai commented Aug 21, 2024

TODO

  • Check the version (yt_libyt, libyt, yt) and print out log to inform the version.
    • I just notice there might be a change in GAMER frontend. (opt_unit)
    • yt_libyt-0.1.0
    • jupyter_libyt-0.1.0
  • Check GitHub Action.

Enhancement

  • Remove some the SET_TIMER flag in append_grid and get_dtype_property. They are too many and corrupt the time profile log file.

Test

  • Example
    • with yt-4.4.dev
    • with yt-4.2
  • GAMER (Plummer)
  • Enzo (Black hole)

@cindytsai
Copy link
Collaborator Author

Hi @hyschive,
I just noticed there is an additional parameter opt_unit in GAMER frontend in yt-4.4.dev.

I think this should be checked and solved in the simulation itself, because libyt is totally agnostic to what Python package it is going to use in the inline script.

What do you think?

Adding these two user param won't affect yt-4.2.
@hyschive
Copy link
Contributor

@cindytsai I'm not sure if I get your point. GAMER does set opt_unit here for libyt.

@cindytsai
Copy link
Collaborator Author

@hyschive Thanks for updating!

I just noticed this bug if the env doesn't have jedi installed.
Py_CompileString(..., ..., Py_file_input) parses the file to display the traceback error. I don't know why if it cannot get the file, then it uses the inline script import. Thus, it is displaying the wrong traceback, because it is parsing the wrong file.
To avoid that, I set the file name to <In [1]>, so when executing codes in Jupyter, it is displaying the error correctly.
We need to free it because it resets the state of the Python functions tracked by libyt.
The design of how API gets called is a bit weird. Will fix this in future update.
@cindytsai cindytsai merged commit 1ec106a into yt-project:main Aug 29, 2024
26 checks passed
@cindytsai cindytsai deleted the Pre-v0.1 branch August 29, 2024 21:07
@cindytsai cindytsai linked an issue Aug 29, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code release
2 participants