Clear the busy flag if GetEvergreenInfo() fails #4461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a crosstool evergreen build, GetEvergreenInfo() is called before SetEvergreenInfo() because of the early call to SbLogRawDumpStack(3) to work around b/151118284. GetEvergreenInfo() doesn't currently release the g_busy flag after it finds invalid g_evergreen_info, and this prevents SetEvergreenInfo() from acquiring it later. b/369808307 Change-Id: Ibcfe894cf3c29be90d731a0fb934690df5b0e89a
y4vor
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a crosstool evergreen build, GetEvergreenInfo() is called before SetEvergreenInfo() because of the early call to SbLogRawDumpStack(3) to work around b/151118284. GetEvergreenInfo() doesn't currently release the g_busy flag after it finds invalid g_evergreen_info, and this prevents SetEvergreenInfo() from acquiring it later.
b/369808307
Change-Id: Ibcfe894cf3c29be90d731a0fb934690df5b0e89a