Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 검색 키워드 컴포넌트 통합 #189
refactor: 검색 키워드 컴포넌트 통합 #189
Changes from 4 commits
40d8e8b
c1ccba3
89dce82
e43ad91
4f1c93c
b8ff074
670a990
957fbd9
a721458
77c2715
9d42100
99f7bcf
baec9cf
8f9899d
c6dd831
68a96d9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IconContext는 여러 개의 아이콘에 동일한 스타일을 적용하기 위한 목적이라서
저도 얼마 전에 앎아이콘 1개에 스타일을 입히는 상황에서는 Icon Component에 바로 넣어서 쓰는 방법도 쓸 수 있습니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인해보니 icon 크기가 figma 디자인과 다른 점이 있어서 같이 수정했습니다 design: figma icon 관련 변경 사항 적용
근데 yds props만으로 해결할 수 없는 부분이 있어서 css를 좀 건드렸는데... 괜찮을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음
흠
음...........
이거 디자인 팀에서
ListItem
을 변형해서 쓴 게 아니라 그냥ListItem
이 아니네요보통 YDS 컴포넌트면 컴포넌트명 옆에 바로가기가 뜨는데
검색어 옆에는 안 뜸 (피그마 Search 페이지 가도 동일하게 안 뜸)
제롬이 채널에 한나 태그해서 올린 메시지 에린도 확인했던데 회의하고 있으면 아마 답장이 오지 않을지 ^^~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
에엥 이거 잘못 확인 하셨다고 스레드에 말씀하시는 게 좋을 것 같아요 ㅜ.ㅜ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분 수정 사항 남은 거 맞나요? 수정 완료 되시면 코멘트나 request review 한 번 더 요청 주세용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넹 남은 거 마자요 회의때 ListItem 말고 li 태그로 바꾸기로 했음 !!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hanna922 리뷰 요청이 다시 안돼서... 태그로도 알람이 가나 모르겠네요
This file was deleted.
This file was deleted.