-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 로그인 / 회원가입 페이지의 TextField를 YDS 컴포넌트로 교체 #182
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6677ddc
refactor: 로그인 페이지 YDS 컴포넌트로 대체
fecapark 151af5c
refactor: 회원가입 페이지 YDS 컴포넌트로 리팩토링
fecapark 3675c08
refactor: hiddenfield를 위한 isMarked 추가
fecapark 07807e8
chore: update pnpm lock file
Hanna922 456695d
refactor: 비밀번호 변경 페이지 PasswordTextField 적용
fecapark dc5db33
refactor: EmailAuth에 SuffixTextField 적용
fecapark 2094289
refactor: EmailForm에 SuffixTextField 적용
fecapark 7ff5dd0
merge: from develop
fecapark fa7e781
refactor: CurrentPasswordForm.tsx 매개변수에 cammel case 적용
fecapark 8e391da
refactor: NewPasswordForm.tsx의 2개 이상의 상태 조합을 변수로 추출
fecapark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
src/home/components/ChangePasswordContents/PasswordInput/PasswordInput.style.ts
This file was deleted.
Oops, something went wrong.
49 changes: 0 additions & 49 deletions
49
src/home/components/ChangePasswordContents/PasswordInput/PasswordInput.tsx
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 변경사항은 아니긴한데 저만
CurrentPasswordForm
prop 매개변수 이름이Props
인게 거슬리나요🤔매개변수도 변수이니 카멜케이스 적용해서
props
가 어떤지 ㅎㅎ..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
매의 눈 이시네용
말씀하신대로 PR 변경사항은 아닌데 , 같이 커밋 날릴게요