Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout related issues #322

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Conversation

SuhasDissa
Copy link
Member

@SuhasDissa SuhasDissa commented Mar 24, 2024

#286
This PR doesn't fix the settings screen layout issues

@SuhasDissa SuhasDissa force-pushed the fix-layout branch 2 times, most recently from b3f1579 to 2000e8d Compare March 25, 2024 12:47
@SuhasDissa
Copy link
Member Author

Fix Alarm time picker overflow

Normal Screen Small Screen
Screenshot_1711370363 Screenshot_1711370551

Note: The Cancel and OK buttons can be accessed by scrolling down

@SuhasDissa
Copy link
Member Author

Fix Timer screen

Number Pad Timer Picker (Normal Screen)

Timer List

Add New Timer Sheet - Number Pad (Normal Screen)

Scroll Time Picker (Normal Screen)

Add New Timer Sheet - Scroll Time Picker (Normal Screen)

Number Pad Timer Picker (Small Screen)

Scroll Time Picker (Small Screen)

@SuhasDissa SuhasDissa marked this pull request as ready for review March 25, 2024 13:04
@Bnyro
Copy link
Member

Bnyro commented Apr 1, 2024

It is possible to make the time picker overflow out of the screen:

screen

Maybe we should limit the height of the preset timers to 1/3 of the screen and make it scrollable?

@Bnyro
Copy link
Member

Bnyro commented Apr 1, 2024

To be honest, I'm not really sure about the new Start button design at the bottom. Can't we just replace it with a floating action button and align it to the right?

@Bnyro
Copy link
Member

Bnyro commented Apr 1, 2024

For the alarm editor, I think it would be great to

  • move the cancel and ok buttons to the bottom right
  • make the cancel button an OutlinedButton, and the ok button a normal Button

@SuhasDissa
Copy link
Member Author

To be honest, I'm not really sure about the new Start button design at the bottom. Can't we just replace it with a floating action button and align it to the right?

One problem I had with the FAB is that it covers the preset timer buttons. I tried adding a bit of a padding under the preset timer grid, but it made the FAB look out of place.

Anyway, I'll add the FAB again.

@SuhasDissa
Copy link
Member Author

For the alarm editor, I think it would be great to

* move the `cancel` and `ok` buttons to the bottom right

* make the `cancel` button an `OutlinedButton`, and the `ok` button a normal `Button`

Like this?

@Bnyro
Copy link
Member

Bnyro commented Apr 8, 2024

Yes 👍

# Conflicts:
#	app/src/main/java/com/bnyro/clock/ui/screens/TimerScreen.kt
@SuhasDissa SuhasDissa merged commit 66b3cd4 into you-apps:main Apr 8, 2024
1 check passed
@SuhasDissa SuhasDissa deleted the fix-layout branch April 10, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants