Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphing): automatically select distinct function names, e.g. f(x), g(x), ... #54

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

Bnyro
Copy link
Member

@Bnyro Bnyro commented Jun 30, 2024

closes #50

@Bnyro Bnyro requested a review from SuhasDissa June 30, 2024 13:39
@SuhasDissa
Copy link
Member

Everything works fine,
I only found one (minor) issue with this.

When I add a function f(x), and then a function g(x) , the next suggested function would be h(x). However, if I remove the f(x) function from the list causing the list length to become 1, the next suggested function name will be g(x).

@Bnyro
Copy link
Member Author

Bnyro commented Jun 30, 2024

Hmm, you're right, it would be best to automatically "update" all existing function names when removing one, so that we always only have f(x), g(x), ...?

@SuhasDissa
Copy link
Member

That'll work

@Bnyro Bnyro merged commit 2fd50d8 into main Oct 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphing: alphabetic function naming scheme or function renaming
2 participants