Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add graphing calculator #45

Merged
merged 1 commit into from
May 8, 2024
Merged

add graphing calculator #45

merged 1 commit into from
May 8, 2024

Conversation

SuhasDissa
Copy link
Member

@SuhasDissa SuhasDissa commented May 4, 2024

TODO:

  • Draw a given function on a graph
  • Pan/Zoom gestures
  • Parse string expressions
  • UI to add/remove equations
  • Dark mode support

@SuhasDissa SuhasDissa requested a review from Bnyro May 6, 2024 11:00
@SuhasDissa SuhasDissa changed the title WIP: add graphing calculator add graphing calculator May 6, 2024
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

I've found some small UX things that we can think about in the future, such as

  • making the color picker simpler to use (and accept hex color strings)
  • finding a better solution than the bottom sheet
  • naming functions differently than f(x)
  • ...

However, I think we should merge this now and discuss other stuff later.

Though I have to admit that I didn't really review 100% of the code because it's just too much - I've tested the graphing calculator extensively however and think that it works pretty great!

@SuhasDissa
Copy link
Member Author

Though I have to admit that I didn't really review 100% of the code because it's just too much - I've tested the graphing calculator extensively however and think that it works pretty great!

I spent a significant amount of time optimizing and testing the math expression parser function. I believe it's stable enough. Only issue it has is that it doesn't support parsing a function inside another function. Which I'll try to fix later.

Also, I'm planning to add these features later,

  • Add support for variables
  • Show the coordinates of a point when clicking on it

@SuhasDissa SuhasDissa merged commit 0e58340 into main May 8, 2024
2 checks passed
@Bnyro Bnyro deleted the graphing branch May 8, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants