feat: Remove MaybeDone for tuple::join (without additional deps)
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm interested in the perf comparison with #74 and the baseline :) |
| $(pub(super) $F: MaybeUninit<$F::Output>),* | ||
| } | ||
|
|
||
| pub(super) struct States { |
There was a problem hiding this comment.
you could use PollStates here
I can run a comparison with the main, my branch, and ours after that :)
There was a problem hiding this comment.
but here's the current results
>> critcmp main patch84 -f tuple::join
group patch84 main
----- ------- ----
tuple::join 10 1.00 213.1±0.96ns ? ?/sec 1.12 239.5±0.56ns ? ?/sec
There was a problem hiding this comment.
PollStates is not no_std since it uses Box, we probably want a static version for tuples and small arrays to avoid lots of small branches
There was a problem hiding this comment.
We have a no_std version of PollStates now: utils::PollArray.
|
Thanks ! Don't worry about this PR if #74 is better I have no problem merging it instead of this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.