-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move iOS and Android SDK to development phase #181
Conversation
WalkthroughThe pull request introduces development-specific modifications across multiple files. The changes primarily focus on conditionally rendering iOS and Android SDK documentation links in the mobile dropdown menu and adding a Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/Layout/MobileGnbDropdown.tsx (1)
90-113
: Consider using a configuration flag or separate environment value for SDK development links.Currently the code checks
process.env.NODE_ENV === 'development'
to conditionally render the iOS/Android SDK sections. While this works correctly for a straightforward dev vs. production setup, you may want to consider using a more granular environment variable (e.g.process.env.NEXT_PUBLIC_SHOW_MOBILE_SDK
) for better control across multiple environments (e.g. staging). This approach can keep dev/production checks focused on build processes and preserve feature toggles for controlling feature availability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
components/Layout/MobileGnbDropdown.tsx
(1 hunks)docs/android-sdk.mdx
(1 hunks)docs/getting-started.mdx
(1 hunks)docs/getting-started/with-android-sdk.mdx
(1 hunks)docs/getting-started/with-ios-sdk.mdx
(1 hunks)docs/ios-sdk.mdx
(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- docs/getting-started.mdx
- docs/ios-sdk.mdx
- docs/android-sdk.mdx
- docs/getting-started/with-android-sdk.mdx
- docs/getting-started/with-ios-sdk.mdx
What this PR does / why we need it?
Move iOS and Android SDK to development phase
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist
Summary by CodeRabbit
New Features
Documentation
phase: development
metadata in various SDK-related documents to categorize their current status.