-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated minikube cluster deployment documentation #158
Conversation
Modify the content of existing documentation that differs from the current yorkie version Changed examples for testing yorkie cluster from CodePair to Quill in the yorkie-js-sdk
WalkthroughThe documentation updates streamline the installation and testing processes for the Yorkie cluster on Minikube by replacing references to "CodePair" with "Quill," a new collaborative code editor. Changes include updated environment variable configurations, revised command instructions, and a focus on ensuring users have accurate guidance for using Quill effectively. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docs/self-hosted-server/minikube.mdx (4 hunks)
Additional comments not posted (2)
docs/self-hosted-server/minikube.mdx (2)
11-11
: Introduction update approved.The introduction correctly reflects the change from CodePair to Quill for testing the Yorkie cluster.
230-281
: Testing instructions update approved.The instructions for testing with Quill are clear and accurately reflect the change from CodePair to Quill. Ensure that the environment variable
VITE_YORKIE_API_ADDR
is correctly set in the.env
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docs/self-hosted-server/minikube.mdx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- docs/self-hosted-server/minikube.mdx
Modify the content of existing documentation that differs from the current yorkie version Changed examples for testing yorkie cluster from CodePair to Quill in the yorkie-js-sdk
What this PR does / why we need it?
The docs for building a yorkie cluster with minikube are expired or missing.
This PR starts by fixing those, and then moves to the Quill example in the yorkie-js-sdk instead of the Code Pair example, which is too heavy for testing clusters.
Any background context you want to provide?
The dependencies for minikube, helm, and istio are specified, but I'm wondering if it's right to not specify the dependencies for npm, pnpm, etc. to run the yorkie-js-sdk.
What are the relevant tickets?
Fixes #156
Checklist
Summary by CodeRabbit