Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong internal document links in mobile view #107

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

g2hhh2ee
Copy link
Contributor

I've updated the internal document filename to "internals.mdx."
This change allows for proper access to /docs/internals in the Mobile View.

What this PR does / why we need it?

To ensure that links to internal document pages work correctly in the Mobile View, I've changed the filename of the internal document to "internals.mdx."

This change primarily emphasizes enhancing user experience. By harmonizing the file name "internals.mdx" with the document's title, it simplifies the process of locating relevant documentation. This consistency in the Mobile View URL structure ensures users can efficiently navigate documentation from different devices.

Any background context you want to provide?

This change doesn't impact the desktop version's user experience, as the previous URL structure remains functional.

What are the relevant tickets?

Fixes #102

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@g2hhh2ee g2hhh2ee changed the title Wrong internal document links in mobile view Fix wrong internal document links in mobile view Oct 25, 2023
@hackerwins hackerwins self-requested a review October 25, 2023 09:17
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit d969365 into yorkie-team:main Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong internal document links in mobile view
2 participants