-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-yorkie-app #690
create-yorkie-app #690
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 69.10% 69.12% +0.02%
==========================================
Files 58 58
Lines 8787 8787
Branches 800 800
==========================================
+ Hits 6072 6074 +2
+ Misses 2455 2454 -1
+ Partials 260 259 -1 ☔ View full report in Codecov by Sentry. |
I think a problem has been fixed on 953c372. |
@se030 I have temporarily granted permission to push to this branch until this PR is merged. @blurfx, @se030 I have two comments: A. If the JS SDK examples are directly included in the create-yorkie-app release, we should consider it has dependencies on the JS SDK. If so, it would be good to use the same version as the JS SDK. Checking the version of create-yorkie-app can help determine which version of the JS SDK it refers to. B. It seems that create-yorkie-app is a CLI. How do you plan to release it? If it is to be installed using |
@hackerwins B. Yes, it should be deployed to npm. |
- add build script for create-yorkie-app - webpack.config) remove unnecessary output.library option and clarify output type as module
so that create-yorkie-app users do not need to configure local Yorkie server
for convenience when adding new examples
- to guide example contributors to update create-yorkie-app - removed unused type property and scripts
7fbb7e6
to
fac0ead
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
Provides CLI starter kit to allow npm users to conveniently scaffold yorkie-based cooperative apps
Provides CLI starter kit to allow npm users to conveniently scaffold yorkie-based cooperative apps
Provides CLI starter kit to allow npm users to conveniently scaffold yorkie-based cooperative apps
I published manually create-yorkie-app to npm. And then I could see the package below. After that, I was able to install create-yorkie-app with Did I miss anything? |
Provides CLI starter kit to allow npm users to conveniently scaffold yorkie-based cooperative apps --------- Co-authored-by: se030 <[email protected]>
Provides CLI starter kit to allow npm users to conveniently scaffold yorkie-based cooperative apps --------- Co-authored-by: se030 <[email protected]>
There seems to be a problem with the code in the overwriting the environment variable file. |
What this PR does / why we need it?
Pulled the
create-yorkie-app
branch that @se030 worked, to fix ci failing issue.Any background context you want to provide?
See #643
What are the relevant tickets?
Checklist