Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example builds failing #689

Closed
wants to merge 2 commits into from
Closed

Conversation

blurfx
Copy link
Member

@blurfx blurfx commented Nov 18, 2023

What this PR does / why we need it?

To fix #643 failing in CI

Any background context you want to provide?

cc. @se030 @hackerwins

What are the relevant tickets?

#643

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@blurfx blurfx requested a review from hackerwins November 18, 2023 15:36
@blurfx blurfx self-assigned this Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3587d1) 67.89% compared to head (4ae6a83) 67.94%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
+ Coverage   67.89%   67.94%   +0.05%     
==========================================
  Files          58       58              
  Lines        8734     8783      +49     
  Branches      784      795      +11     
==========================================
+ Hits         5930     5968      +38     
- Misses       2546     2555       +9     
- Partials      258      260       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blurfx blurfx closed this Nov 18, 2023
@blurfx blurfx deleted the fix/create-yorkie-app-ci-fail branch November 18, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant