-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce basic architecture to support undo and redo #650
Conversation
Co-authored-by: Yourim Cha <[email protected]>
Co-authored-by: Yourim Cha <[email protected]>
Co-authored-by: Yourim Cha <[email protected]>
…yorkie-js-sdk into feat/undo-redo-arch
…yorkie-js-sdk into feat/undo-redo-arch
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 88.88% 89.19% +0.31%
==========================================
Files 80 79 -1
Lines 8958 9318 +360
Branches 825 856 +31
==========================================
+ Hits 7962 8311 +349
- Misses 688 694 +6
- Partials 308 313 +5
☔ View full report in Codecov by Sentry. |
7917aad
to
2e87b88
Compare
2e87b88
to
763aa40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
What this PR does / why we need it?
This is a new branch created by splitting commits related to only the basic architecture from PR #635.
It's the initial version of multi-user undo/redo implementation. For now, it's focusing on implementing an architecture to support undo/redo using liveblocks as a reference.
This PR contains these actions:
Presence.Set
Counter.Increase
The following tasks should be:
Object.Set
,Text.Edit
and so onAny background context you want to provide?
Additional information about multi-user undo/redo is at yorkie-team/yorkie#49.
What are the relevant tickets?
Address yorkie-team/yorkie#652
Checklist