Skip to content

Commit

Permalink
Uncomment TODO in test
Browse files Browse the repository at this point in the history
  • Loading branch information
hackerwins committed Nov 20, 2024
1 parent 2846be1 commit 17926ef
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions packages/sdk/test/integration/gc_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1689,12 +1689,9 @@ describe('Garbage Collection', function () {
assert.equal(doc2.getGarbageLen(), 2);
assert.equal(doc2.getVersionVector().size(), 2);

// TODO(JOOHOJANG): remove below comments after https://github.com/yorkie-team/yorkie/issues/1058 resolved
// Due to https://github.com/yorkie-team/yorkie/issues/1058, removing deactivated client's version vector is not working properly now.

//await client2.sync();
//assert.equal(doc2.getGarbageLen(), 0);
//assert.equal(doc2.getVersionVector().size(), 1);
await client2.sync();
assert.equal(doc2.getGarbageLen(), 0);
assert.equal(doc2.getVersionVector().size(), 1);
});

it('attach > pushpull > detach lifecycle version vector test (run gc at last client detaches document, but no tombstone exsits)', async function ({
Expand Down

0 comments on commit 17926ef

Please sign in to comment.