Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint rules #710

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

toasted-nutbread
Copy link

This change turns on a few rules:

  • no-octal - this was inadvertently set to off, no changes were required.
  • no-octal-escape - this was inadvertently set to off, no changes were required.
  • @typescript-eslint/no-redundant-type-constituents - enabled this, only had one issue to resolve in a type file.
  • @typescript-eslint/no-floating-promises - this is the big one, requires either await or void for async functions. This should help prevent issues where sync functions are subsequently changed to async, or just situations where someone might forget. It makes the intent required to be more explicit. Unfortunately, there were about 300 places in the code that needed this to be addressed. Most of which were turned to void, which is the existing behaviour, and only a few were changed to await.

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner February 18, 2024 21:49
Copy link

github-actions bot commented Feb 18, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! I had to turn on no-floating-promises for the files I was working in when I was doing my performance-batching changes at it was simply too hard to do a sync->async refactor without it. This is great to have.

@djahandarie djahandarie added this pull request to the merge queue Feb 19, 2024
Merged via the queue into yomidevs:master with commit 2da866f Feb 19, 2024
7 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants