Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change turns on a few rules:
no-octal
- this was inadvertently set to off, no changes were required.no-octal-escape
- this was inadvertently set to off, no changes were required.@typescript-eslint/no-redundant-type-constituents
- enabled this, only had one issue to resolve in a type file.@typescript-eslint/no-floating-promises
- this is the big one, requires eitherawait
orvoid
forasync
functions. This should help prevent issues where sync functions are subsequently changed to async, or just situations where someone might forget. It makes the intent required to be more explicit. Unfortunately, there were about 300 places in the code that needed this to be addressed. Most of which were turned tovoid
, which is the existing behaviour, and only a few were changed toawait
.