Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable kana conversion on search page for other languages #705

Merged

Conversation

StefanVukovic99
Copy link
Collaborator

image
image
(The HTML is just moved around a little so it doesn't jump when the kana option dissapears)

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner February 17, 2024 20:50
Copy link

github-actions bot commented Feb 17, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@toasted-nutbread
Copy link

toasted-nutbread commented Feb 17, 2024

Based on the screenshots you shared, can you make the left side of the search box and the left side of the profile dropdown be aligned? It looks like there is currently an offset of a few pixels.

@djahandarie djahandarie added this pull request to the merge queue Feb 18, 2024
Merged via the queue into yomidevs:master with commit 251db01 Feb 18, 2024
7 of 8 checks passed
@djahandarie djahandarie added the kind/enhancement The issue or PR is a new feature or request label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants