Language descriptors organization #704

toasted-nutbread · 2024-02-17T20:46:47Z

Based on some comments I left in here: #684 (comment)

Here is an example of organizing the language descriptors a bit more. This should have a few effects if we use this proposal:

Less changes to multiple files if we need to make changes that affect multiple things.
Less fragmentation across multiple files.
Less need to reconfigure eslint or jsconfig configuration files each time a new language is added or changed.

github-actions · 2024-02-17T20:49:15Z

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

ext/js/language/ja/japanese-text-preprocessors.js

toasted-nutbread added 9 commits February 17, 2024 15:06

Move languageDescriptorMap

003c5cc

Move text preprocessors

f707d17

Merge into language-descriptors.js

60966b5

Merge typescript

c3d74c9

Initialize inline

2c17a4b

Move types

eb96354

Update types

c750721

Update eslint

2d11686

Update jsconfig reference

aa690a5

toasted-nutbread requested a review from StefanVukovic99 February 17, 2024 20:46

toasted-nutbread requested a review from a team as a code owner February 17, 2024 20:46

StefanVukovic99 reviewed Feb 17, 2024

View reviewed changes

ext/js/language/ja/japanese-text-preprocessors.js Outdated Show resolved Hide resolved

StefanVukovic99 approved these changes Feb 17, 2024

View reviewed changes

Rename

4933653

toasted-nutbread mentioned this pull request Feb 18, 2024

add more languages #684

Merged

djahandarie approved these changes Feb 18, 2024

View reviewed changes

djahandarie added this pull request to the merge queue Feb 18, 2024

Merged via the queue into yomidevs:master with commit c48cd6f Feb 18, 2024
7 checks passed

djahandarie added the kind/meta The issue or PR is meta label Feb 25, 2024

Provide feedback