Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vitests idiomatic #677

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

toasted-nutbread
Copy link

Resolves #472.

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner February 11, 2024 22:53
Copy link

github-actions bot commented Feb 11, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

djahandarie
djahandarie previously approved these changes Feb 15, 2024
Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs conflict resolution.

@djahandarie djahandarie added this pull request to the merge queue Feb 17, 2024
Merged via the queue into yomidevs:master with commit 1e69210 Feb 17, 2024
7 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests should be updated to be more idiomatic for vitest
2 participants