kbn-handlebars dependency update #613
Conversation
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
|
Agreed that this is cleaner. I invited you as a member to themoeway github org, so once you accept that, you should be able to transfer the repo. I will also make sure the branch protections on it are set up properly, as that is basically our main security control for everything we do, and I'd like to make sure it's set up for all yomitan-related projects. |
|
Okay I've transferred the repo and updated the refs. I also updated the readme a little, but it's a little bit hard to attribute the same way as the others since it's a custom fork of a sub-folder of a mono-repo. |
|
Thanks! Is that the output of |
|
It's not, I didn't realize that's how that was generated. This is the output:
Which is not super meaningful for it, as I think it's always been version 1.0.0, and the n/a comes from me just directly cloning the folder contents without any metadata setup in package.json |
|
@toasted-nutbread I think I'd prefer just sticking to the output of that command even if it's kind of useless. I think we should optimize for maintainability than having perfect legal references. That said feel free to do whatever you want, I'll merge. (Just needs a merge conflict fix at least) |
toasted-nutbread
force-pushed
the
kbn-handlebars-dependency-update
branch
from
f4de700 to
111592c
Compare
CodSpeed Performance ReportMerging #613 will not alter performanceComparing Summary
|
In lieu of elastic/kibana creating a npm package, how about we do something like this for this dependency? At the very least, this takes its code out of the repo and offloads any maintenance into a separate repo. Right now, it's referencing a repo that I set up, but it should realistically be something that is in themoeway's organization. If this works out, let me know if I can help with that.
Something else I've thought of a few times is that if it's possible to make handlebars support async functions, a lot of the Anki note generation process could be able to be simplified. The fact that it's limited right now to being synchronous causes a lot of problems that make it difficult to add and maintain certain functionality. So that may lend to some justification of just hosting a fork of kbn-handlebars and potentially investigating to see if changes could be made to it that would help specifically this project.
This presumably resolves #525.
Should allow #529 to work.