Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to welcome page configuration #579

Closed

Conversation

piercemorris
Copy link

Part of #470 to reconfigure settings to the welcome page.

  • Default to not showing welcome page on browser start-up
  • Open welcome page on extension installed event
  • Use chrome.storage.local to persist user options for opening the welcome page
  • Rename showGuide to showWelcomePage for readability/understanding

@toasted-nutbread let me know what you think? I know there is a setting for disabling the welcome page but personally I think it should be default turned off, and only on extension start up. However, as part of the issue we could make it more obvious where to find the welcome page, should you need to.

@piercemorris piercemorris requested a review from a team as a code owner January 25, 2024 16:13
Copy link

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie
Copy link
Collaborator

Default to not showing welcome page on browser start-up

Hmm, if we do this, I can't imagine anyone would go in and flip the toggle to turn the welcome page on on startup, so we should also get rid of that toggle entirely if we decide to do this. (I.e., the intent of the toggle was to enable an opt-out workflow. An opt-in workflow makes no sense for this.)

Overall, the major benefit of the opt-out workflow is that it ensure people have actually seen the welcome page and read it at least closely enough to learn how to get rid of it. There is some important information on there, especially about permissions, which if you miss, the extension is basically broken/useless, and many people would not realize they missed a setup step, they'd simply assume the extension doesn't work.

I think we can make some UX improvements on the welcome page (such as making it a clear and minimal "step 1, 2, 3" sort of thing), and perhaps even then simply change the logic to no longer show the welcome page if/when those basic steps have been taken, so there is no need for a special toggle for it. It would become more like just a required setup flow.

What do you think?

@piercemorris
Copy link
Author

What do you think?

Yeah that's a very good explanation of an ideal workflow I reckon, it would take some time to actually go ahead and rework the welcome page itself but I will give it a go. If you have any idea about how you want it to look then give us a ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants