Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix project header wrapping #521

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

Casheeew
Copy link
Member

For some device with small screens, putting badges on the same line as the project header (Yomitan) might exceed the print width. This causes it to wrap around, which is not good UI.

@Casheeew Casheeew requested a review from a team as a code owner January 14, 2024 07:34
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie
Copy link
Collaborator

Can we fix it with just using "chrome" and "firefox" as the labels?

@Casheeew
Copy link
Member Author

Can we fix it with just using "chrome" and "firefox" as the labels?

On mobiles, the text is pretty large either way.

image (before) vs
image (after)

chrome release does sound more concise than chrome release (stable), maybe even just chrome is better.

@djahandarie djahandarie added this pull request to the merge queue Jan 20, 2024
Merged via the queue into yomidevs:master with commit 1524cf1 Jan 20, 2024
6 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants