Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit passive option to touchstart event #480

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Add explicit passive option to touchstart event #480

merged 1 commit into from
Dec 29, 2023

Conversation

toasted-nutbread
Copy link

This change suppresses some warnings:

display-resizer.js:48 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event.
Consider marking event handler as 'passive' to make the page more responsive.
See https://www.chromestatus.com/feature/5745543795965952

core.js:460 [Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event.
Consider marking event handler as 'passive' to make the page more responsive.
See https://www.chromestatus.com/feature/5745543795965952

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner December 28, 2023 23:19
@github-actions GitHub Actions
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie djahandarie added this pull request to the merge queue Dec 29, 2023
Merged via the queue into yomidevs:master with commit c13ee62 Dec 29, 2023
5 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djahandarie djahandarie djahandarie approved these changes

Assignees
No one assigned
Labels
kind/meta The issue or PR is meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toasted-nutbread @djahandarie