forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event dispatcher refactor #463
Merged
djahandarie
merged 27 commits into
yomidevs:master
from
toasted-nutbread:event-dispatcher-refactor
Dec 29, 2023
Merged
Event dispatcher refactor #463
djahandarie
merged 27 commits into
yomidevs:master
from
toasted-nutbread:event-dispatcher-refactor
Dec 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
reviewed
Dec 28, 2023
toasted-nutbread
force-pushed
the
event-dispatcher-refactor
branch
from
December 28, 2023 14:15
433c921
to
0a53541
Compare
djahandarie
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another change to improve the overall type safety of the extension. This time, event listeners now have type safety enforced in a manner similar to what is done for the API maps.