Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IIFEs #452

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Remove IIFEs #452

merged 5 commits into from
Dec 27, 2023

Conversation

Casheeew
Copy link
Member

related: #384

@Casheeew Casheeew requested a review from a team as a code owner December 26, 2023 07:31
@Casheeew Casheeew closed this Dec 26, 2023
@Casheeew Casheeew deleted the accessibility-updates branch December 26, 2023 07:32
@Casheeew Casheeew restored the accessibility-updates branch December 26, 2023 07:32
@Casheeew Casheeew reopened this Dec 26, 2023
Copy link

github-actions bot commented Dec 26, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

ext/js/app/content-script-wrapper.js Outdated Show resolved Hide resolved
ext/js/accessibility/google-docs.js Outdated Show resolved Hide resolved
@djahandarie
Copy link
Collaborator

djahandarie commented Dec 27, 2023

Playwright seems to be failing:

Error: page.waitForEvent: Timeout 60000ms exceeded while waiting for event "frameattached"
=========================== logs ===========================
waiting for event "frameattached"
============================================================

  62 |         let frame_attached;
  63 |         if (popup_frame === undefined) {
> 64 |             frame_attached = page.waitForEvent('frameattached');
     |                                   ^
  65 |         }
  66 |         await page.mouse.move(box.x + offset.x, box.y + offset.y, {steps: 10}); // hover over the test
  67 |         if (popup_frame === undefined) {

    at screenshot (/home/runner/work/yomitan/yomitan/test/playwright/visual.spec.js:64:35)
    at /home/runner/work/yomitan/yomitan/test/playwright/visual.spec.js:101:9

do you know why?

@Casheeew
Copy link
Member Author

Playwright seems to be failing:

Error: page.waitForEvent: Timeout 60000ms exceeded while waiting for event "frameattached"
=========================== logs ===========================
waiting for event "frameattached"
============================================================

  62 |         let frame_attached;
  63 |         if (popup_frame === undefined) {
> 64 |             frame_attached = page.waitForEvent('frameattached');
     |                                   ^
  65 |         }
  66 |         await page.mouse.move(box.x + offset.x, box.y + offset.y, {steps: 10}); // hover over the test
  67 |         if (popup_frame === undefined) {

    at screenshot (/home/runner/work/yomitan/yomitan/test/playwright/visual.spec.js:64:35)
    at /home/runner/work/yomitan/yomitan/test/playwright/visual.spec.js:101:9

do you know why?

Weird. Perhaps it is indeed not working with the content-script-wrapper after all.

@djahandarie djahandarie added this pull request to the merge queue Dec 27, 2023
@toasted-nutbread
Copy link

Weird. Perhaps it is indeed not working with the content-script-wrapper after all.

I think this is what I ran into as well.

Merged via the queue into yomidevs:master with commit 60cd218 Dec 27, 2023
5 checks passed
@Casheeew Casheeew deleted the accessibility-updates branch December 27, 2023 23:33
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants