Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Timer class #401

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

toasted-nutbread
Copy link

This class is generally not used any more and probably has little utility for any significant testing. The last time this was used was probably to profile the removal of Dexie in favor of native IndexedDB.

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner December 19, 2023 20:56
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should definitely consider introducing some standard benchmarking mechanism/library (#87) but I agree this is probably not it so makes sense to remove.

@djahandarie djahandarie added this pull request to the merge queue Dec 20, 2023
Merged via the queue into yomidevs:master with commit d6dcf82 Dec 20, 2023
5 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants