Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ambiguously named variables #392

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

Casheeew
Copy link
Member

Some variables are ambiguously named, e.g stylesheet1, stylesheet2, content1, content2. This change renames them into more semantically meaningful names.

@Casheeew Casheeew requested a review from a team as a code owner December 19, 2023 10:59
@Casheeew Casheeew changed the title Rename variables Rename ambiguously named variables Dec 19, 2023
Copy link

github-actions bot commented Dec 19, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

djahandarie
djahandarie previously approved these changes Dec 19, 2023
Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though personally I'd prefer ruleIndex and styleIndex if we're trying to be explicit. (Feel free to change it, otherwise will merge as-is later.)

@djahandarie djahandarie added this pull request to the merge queue Dec 19, 2023
Merged via the queue into yomidevs:master with commit 67846dc Dec 19, 2023
5 checks passed
@Casheeew Casheeew deleted the rename-variables branch December 19, 2023 11:18
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants