Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update JSDoc comments #387

Merged
merged 21 commits into from
Dec 19, 2023
Merged

update JSDoc comments #387

merged 21 commits into from
Dec 19, 2023

Conversation

Casheeew
Copy link
Member

This change adds @toasted-nutbread's suggestions in #355 .
I was intending to work on that PR a little longer, but I think I have resolved the comments in that PR by mistake. However, this PR should include all changes suggested.

I decided to remove @example comments until eslint-plugin-jsdoc's check-examples rule works well with ESLint 8, except for in Deinflector class because I think the class is not likely to be changed much. I also removed unneccessary comments.

@Casheeew Casheeew requested a review from a team as a code owner December 19, 2023 04:32
Copy link

github-actions bot commented Dec 19, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

djahandarie
djahandarie previously approved these changes Dec 19, 2023
@djahandarie djahandarie added this pull request to the merge queue Dec 19, 2023
Merged via the queue into yomidevs:master with commit 5f96276 Dec 19, 2023
5 checks passed
@Casheeew Casheeew mentioned this pull request Dec 19, 2023
@Casheeew Casheeew deleted the development branch December 19, 2023 14:44
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants