Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all occurrences of よみちゃん / ヨミチャン with よみたん / ヨミタン #377

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Replace all occurrences of よみちゃん / ヨミチャン with よみたん / ヨミタン #377

merged 1 commit into from
Dec 18, 2023

Conversation

Casheeew
Copy link
Member

Replace all occurrences of よみちゃん / ヨミチャン with よみたん / ヨミタン

@Casheeew Casheeew requested a review from a team as a code owner December 18, 2023 10:24
@github-actions GitHub Actions
Copy link

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

djahandarie
djahandarie approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Visual differences in playwright tests are as expected.

@djahandarie djahandarie added this pull request to the merge queue Dec 18, 2023
Merged via the queue into yomidevs:master with commit eb7bf95 Dec 18, 2023
6 checks passed
@Casheeew Casheeew deleted the replace-yomichan-occurrences branch December 18, 2023 10:41
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djahandarie djahandarie djahandarie approved these changes

Assignees
No one assigned
Labels
kind/meta The issue or PR is meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Casheeew @djahandarie