-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test fixtures #371
Test fixtures #371
Conversation
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
FYI, if you open PR2 against the branch of PR1, GitHub actually handles it pretty nicely, and will redirect your PR2 to be against master once PR1 is merged. It can help with not needing to redo stuff when you have lots of interdependent PRs open. IIRC. |
I tried but that didn't work because it would open a PR on my fork repo. But maybe I did it wrong. Either way it's not a problem for me. |
bdafcef
to
fd88bee
Compare
Ah, right, I was doing it all within branches on this repo, which is why it worked for me. Ah well. |
This change makes translator.tests.js and anki-note-builder.tests.js more idiomatic. It does a little bit of cleanup in the test files themselves, and it removes the need for TranslatorVM by creating a reusable test function which contains the relevant context.
This will need to be rebased after #370 is merged.