Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixtures #371

Merged
merged 13 commits into from
Dec 19, 2023
Merged

Test fixtures #371

merged 13 commits into from
Dec 19, 2023

Conversation

toasted-nutbread
Copy link

This change makes translator.tests.js and anki-note-builder.tests.js more idiomatic. It does a little bit of cleanup in the test files themselves, and it removes the need for TranslatorVM by creating a reusable test function which contains the relevant context.

This will need to be rebased after #370 is merged.

Copy link

github-actions bot commented Dec 17, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie
Copy link
Collaborator

djahandarie commented Dec 18, 2023

This will need to be rebased after #370 is merged.

FYI, if you open PR2 against the branch of PR1, GitHub actually handles it pretty nicely, and will redirect your PR2 to be against master once PR1 is merged. It can help with not needing to redo stuff when you have lots of interdependent PRs open. IIRC.

@toasted-nutbread
Copy link
Author

FYI, if you open PR2 against the branch of PR1, GitHub actually handles it pretty nicely, and will redirect your PR2 to be against master once PR1 is merged. It can help with not needing to redo stuff when you have lots of interdependent PRs open. IIRC.

I tried but that didn't work because it would open a PR on my fork repo. But maybe I did it wrong. Either way it's not a problem for me.

@toasted-nutbread toasted-nutbread marked this pull request as ready for review December 18, 2023 14:36
@toasted-nutbread toasted-nutbread requested a review from a team as a code owner December 18, 2023 14:36
@djahandarie
Copy link
Collaborator

I tried but that didn't work because it would open a PR on my fork repo. But maybe I did it wrong. Either way it's not a problem for me.

Ah, right, I was doing it all within branches on this repo, which is why it worked for me. Ah well.

@djahandarie djahandarie added this pull request to the merge queue Dec 19, 2023
Merged via the queue into yomidevs:master with commit 46821ee Dec 19, 2023
5 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants