Update eslint spacing rules #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
previously approved these changes
Dec 17, 2023
themoeway-bot
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables two eslint settings:
no-multi-spaces- Disallows multiple spaces other than indentation. This is intended to reduce stylistic inconsistencies which usually result from a user typo. However, there are several situations in the codebase where space alignment is useful. As such, those locations explicitly turn off the rule, and may subsequently turn it back on.space-infix-ops- Makes spacing more clear around operators. This primarily affects how default parameters were assigned, which used Python-like assignments without spaces, such asconst {x=1} = value;. Enabling this option also helps fix issues with spacing which usually result from user error. This was originally discussed in Eslint stylistic rules FooSoft/yomichan#363 and we opted to not enable it at that time.Since the project is in a considerably different state at this point, I think these rules should be enabled moving forward, as it increases the level of stylistic code strictness. This should have benefits for the codebase, as it looks to have multiple (somewhat) active developers.